[PATCH] drm/amdgpu: don't try to unreserve NULL pointer

James Zhu jamesz at amd.com
Mon Sep 17 18:41:48 UTC 2018



On 2018-09-17 02:07 PM, Christian König wrote:
> Don't try to unreserve a BO we doesn't allocated.
>
> Fixes: 07012fdd497e drm/amdgpu: don't allocate zero sized kernel BOs
>
> Signed-off-by: Christian König <christian.koenig at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> index 84d82d5382f9..c1387efc0c91 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> @@ -348,7 +348,8 @@ int amdgpu_bo_create_kernel(struct amdgpu_device *adev,
>   	if (r)
>   		return r;
>   
> -	amdgpu_bo_unreserve(*bo_ptr);
> +	if (*bo_ptr)
Can we put this check inside ttm_bo_unreserve?
James Zhu
> +		amdgpu_bo_unreserve(*bo_ptr);
>   
>   	return 0;
>   }



More information about the amd-gfx mailing list