[PATCH] drm/amdgpu: don't try to unreserve NULL pointer

[Christian König]

Am 17.09.2018 um 20:41 schrieb James Zhu:
>
>
> On 2018-09-17 02:07 PM, Christian König wrote:
>> Don't try to unreserve a BO we doesn't allocated.
>>
>> Fixes: 07012fdd497e drm/amdgpu: don't allocate zero sized kernel BOs
>>
>> Signed-off-by: Christian König <christian.koenig at amd.com>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c 
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> index 84d82d5382f9..c1387efc0c91 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> @@ -348,7 +348,8 @@ int amdgpu_bo_create_kernel(struct amdgpu_device 
>> *adev,
>>       if (r)
>>           return r;
>>   -    amdgpu_bo_unreserve(*bo_ptr);
>> +    if (*bo_ptr)
> Can we put this check inside ttm_bo_unreserve?

No, calling amdgpu_bo_unreserve() with a NULL pointer is certainly a bug.

Christian.

> James Zhu
>> +        amdgpu_bo_unreserve(*bo_ptr);
>>         return 0;
>>   }
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx