[PATCH] drm/amdgpu: Fix copy error in uvd_v6/7_0.c

Zhu, Rex Rex.Zhu at amd.com
Wed Sep 26 13:49:58 UTC 2018


Ok. I will remove the code.


Best Regards

Rex


________________________________
From: Christian König <ckoenig.leichtzumerken at gmail.com>
Sent: Wednesday, September 26, 2018 8:45 PM
To: Zhu, Rex; amd-gfx at lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: Fix copy error in uvd_v6/7_0.c

Am 26.09.2018 um 14:41 schrieb Rex Zhu:
> Signed-off-by: Rex Zhu <Rex.Zhu at amd.com>

Actually that code can just be removed because uvd_*_enc_get_destroy_msg
is only called with direct=true.

Christian.

> ---
>   drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 2 +-
>   drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
> index 8ef4a53..2ceab76 100644
> --- a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
> @@ -313,7 +313,7 @@ static int uvd_v6_0_enc_get_destroy_msg(struct amdgpu_ring *ring,
>        if (direct)
>                r = amdgpu_job_submit_direct(job, ring, &f);
>        else
> -             r = amdgpu_job_submit(job, &ring->adev->vce.entity,
> +             r = amdgpu_job_submit(job, &ring->adev->uvd.entity,
>                                      AMDGPU_FENCE_OWNER_UNDEFINED, &f);
>        if (r)
>                goto err;
> diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c b/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c
> index a289f6a..31a9665 100644
> --- a/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c
> @@ -320,7 +320,7 @@ int uvd_v7_0_enc_get_destroy_msg(struct amdgpu_ring *ring, uint32_t handle,
>        if (direct)
>                r = amdgpu_job_submit_direct(job, ring, &f);
>        else
> -             r = amdgpu_job_submit(job, &ring->adev->vce.entity,
> +             r = amdgpu_job_submit(job, &ring->adev->uvd.entity,
>                                      AMDGPU_FENCE_OWNER_UNDEFINED, &f);
>        if (r)
>                goto err;

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20180926/88031f8a/attachment.html>


More information about the amd-gfx mailing list