[PATCH] drm/amd/amdgpu: Fix offset for vmid selection in debugfs interface

Deucher, Alexander Alexander.Deucher at amd.com
Wed Jul 17 13:50:47 UTC 2019


RB,

thanks,

Alex
________________________________
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> on behalf of StDenis, Tom <Tom.StDenis at amd.com>
Sent: Wednesday, July 17, 2019 8:44 AM
To: Koenig, Christian; amd-gfx at lists.freedesktop.org
Subject: Re: [PATCH] drm/amd/amdgpu: Fix offset for vmid selection in debugfs interface

Thanks.


Alex can I grab an R-b please?


Cheers,

Tom

On 2019-07-16 7:30 a.m., Christian König wrote:
> Am 16.07.19 um 13:24 schrieb StDenis, Tom:
>> The register debugfs interface was using the wrong bitmask for vmid
>> selection for GFX_CNTL.
>>
>> Signed-off-by: Tom St Denis <tom.stdenis at amd.com>
>
> Acked-by: Christian König <christian.koenig at amd.com>
>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
>> index 87b32873046f..59849ed9797d 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
>> @@ -132,7 +132,7 @@ static int amdgpu_debugfs_process_reg_op(bool
>> read, struct file *f,
>>           me = (*pos & GENMASK_ULL(33, 24)) >> 24;
>>           pipe = (*pos & GENMASK_ULL(43, 34)) >> 34;
>>           queue = (*pos & GENMASK_ULL(53, 44)) >> 44;
>> -        vmid = (*pos & GENMASK_ULL(48, 45)) >> 54;
>> +        vmid = (*pos & GENMASK_ULL(58, 54)) >> 54;
>>             use_ring = 1;
>>       } else {
>
_______________________________________________
amd-gfx mailing list
amd-gfx at lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20190717/077e2425/attachment-0001.html>


More information about the amd-gfx mailing list