[PATCH] drm/amdkfd/kfd_mqd_manager_v10: Fix missing break in switch statement

Deucher, Alexander Alexander.Deucher at amd.com
Mon Jul 22 15:58:00 UTC 2019

We need to add a /*fall through */ comment then.

From: Liu, Shaoyun <Shaoyun.Liu at amd.com>
Sent: Monday, July 22, 2019 11:14 AM
To: Gustavo A. R. Silva <gustavo at embeddedor.com>; Cox, Philip <Philip.Cox at amd.com>; Oded Gabbay <oded.gabbay at gmail.com>; Deucher, Alexander <Alexander.Deucher at amd.com>; Koenig, Christian <Christian.Koenig at amd.com>; Zhou, David(ChunMing) <David1.Zhou at amd.com>; David Airlie <airlied at linux.ie>; Daniel Vetter <daniel at ffwll.ch>
Cc: amd-gfx at lists.freedesktop.org <amd-gfx at lists.freedesktop.org>; dri-devel at lists.freedesktop.org <dri-devel at lists.freedesktop.org>; linux-kernel at vger.kernel.org <linux-kernel at vger.kernel.org>
Subject: Re: [PATCH] drm/amdkfd/kfd_mqd_manager_v10: Fix missing break in switch statement

This one properly in purpose , The mqd init for CP and  COMPUTE will
have the same  routine .



On 2019-07-21 6:59 p.m., Gustavo A. R. Silva wrote:
> Add missing break statement in order to prevent the code from falling
> through to case KFD_MQD_TYPE_COMPUTE.
> This bug was found thanks to the ongoing efforts to enable
> -Wimplicit-fallthrough.
> Fixes: 14328aa58ce5 ("drm/amdkfd: Add navi10 support to amdkfd. (v3)")
> Cc: stable at vger.kernel.org
> Signed-off-by: Gustavo A. R. Silva <gustavo at embeddedor.com>
> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c | 1 +
>   1 file changed, 1 insertion(+)
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c b/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c
> index 4f8a6ffc5775..1d8b13ad46f9 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c
> @@ -430,6 +430,7 @@ struct mqd_manager *mqd_manager_init_v10(enum KFD_MQD_TYPE type,
>        switch (type) {
>        case KFD_MQD_TYPE_CP:
>                pr_debug("%s@%i\n", __func__, __LINE__);
> +             break;
>        case KFD_MQD_TYPE_COMPUTE:
>                pr_debug("%s@%i\n", __func__, __LINE__);
>                mqd->allocate_mqd = allocate_mqd;
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20190722/6d07d74b/attachment.html>

More information about the amd-gfx mailing list