[PATCH] Revert "drm/amd/display: Enable fast plane updates when state->allow_modeset = true"

[Mike Lothian]

Just FYI my system was Raven1 not Raven2

On Thu, 20 Jun 2019 at 13:34, Nicholas Kazlauskas
<nicholas.kazlauskas at amd.com> wrote:
>
> This reverts commit ebc8c6f18322ad54275997a888ca1731d74b711f.
>
> There are still missing corner cases with cursor interaction and these
> fast plane updates on Picasso and Raven2 leading to endless PSTATE
> warnings for typical desktop usage depending on the userspace.
>
> This change should be reverted until these issues have been resolved.
>
> Cc: David Francis <david.francis at amd.com>
> Cc: Harry Wentland <harry.wentland at amd.com>
> Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas at amd.com>
> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 33dcd4187157..d6acbcfa570c 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -6471,6 +6471,14 @@ static bool should_reset_plane(struct drm_atomic_state *state,
>         struct drm_crtc_state *new_crtc_state;
>         int i;
>
> +       /*
> +        * TODO: Remove this hack once the checks below are sufficient
> +        * enough to determine when we need to reset all the planes on
> +        * the stream.
> +        */
> +       if (state->allow_modeset)
> +               return true;
> +
>         /* Exit early if we know that we're adding or removing the plane. */
>         if (old_plane_state->crtc != new_plane_state->crtc)
>                 return true;
> --
> 2.17.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx