[PATCH] Revert "drm/amd/display: Enable fast plane updates when state->allow_modeset = true"

[Kazlauskas, Nicholas]

Sure, it's https://bugs.freedesktop.org/show_bug.cgi?id=110949 .

I've added it to the commit, thanks.

Nicholas Kazlauskas

On 6/20/19 10:35 AM, Deucher, Alexander wrote:
Is there a bugzilla this fixes?  If so, can you add a link?

Alex
________________________________
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org><mailto:amd-gfx-bounces at lists.freedesktop.org> on behalf of Francis, David <David.Francis at amd.com><mailto:David.Francis at amd.com>
Sent: Thursday, June 20, 2019 9:43 AM
To: Kazlauskas, Nicholas; amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org>
Cc: Wentland, Harry
Subject: Re: [PATCH] Revert "drm/amd/display: Enable fast plane updates when state->allow_modeset = true"


Reviewed-by: David Francis <david.francis at amd.com><mailto:david.francis at amd.com>



________________________________
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org><mailto:amd-gfx-bounces at lists.freedesktop.org> on behalf of Nicholas Kazlauskas <nicholas.kazlauskas at amd.com><mailto:nicholas.kazlauskas at amd.com>
Sent: June 20, 2019 8:34:03 AM
To: amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org>
Cc: Francis, David; Wentland, Harry; Kazlauskas, Nicholas
Subject: [PATCH] Revert "drm/amd/display: Enable fast plane updates when state->allow_modeset = true"

This reverts commit ebc8c6f18322ad54275997a888ca1731d74b711f.

There are still missing corner cases with cursor interaction and these
fast plane updates on Picasso and Raven2 leading to endless PSTATE
warnings for typical desktop usage depending on the userspace.

This change should be reverted until these issues have been resolved.

Cc: David Francis <david.francis at amd.com><mailto:david.francis at amd.com>
Cc: Harry Wentland <harry.wentland at amd.com><mailto:harry.wentland at amd.com>
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas at amd.com><mailto:nicholas.kazlauskas at amd.com>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 33dcd4187157..d6acbcfa570c 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -6471,6 +6471,14 @@ static bool should_reset_plane(struct drm_atomic_state *state,
         struct drm_crtc_state *new_crtc_state;
         int i;

+       /*
+        * TODO: Remove this hack once the checks below are sufficient
+        * enough to determine when we need to reset all the planes on
+        * the stream.
+        */
+       if (state->allow_modeset)
+               return true;
+
         /* Exit early if we know that we're adding or removing the plane. */
         if (old_plane_state->crtc != new_plane_state->crtc)
                 return true;
--
2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org>
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20190620/135fbe92/attachment-0001.html>