[PATCH 2/2] drm/amdgpu/display: switch udelay to msleep

Zhang, Hawking Hawking.Zhang at amd.com
Tue Jun 25 15:26:33 UTC 2019

Series is Reviewed-by: Hawking Zhang <Hawking.Zhang at amd.com>

-----Original Message-----
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Alex Deucher
Sent: 2019年6月25日 21:59
To: amd-gfx at lists.freedesktop.org
Cc: Deucher, Alexander <Alexander.Deucher at amd.com>
Subject: [PATCH 2/2] drm/amdgpu/display: switch udelay to msleep

We may need to sleep for up to 80ms:

/* First DPCD read after VDD ON can fail if the particular board
 * does not have HPD pin wired correctly. So if DPCD read fails,
 * which it should never happen, retry a few times. Target worst
 * case scenario of 80 ms.

Switch udelay to msleep to avoid limits on arm.

Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
 drivers/gpu/drm/amd/display/dc/core/dc_link.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
index d6f8be654c2e..c17db5c144aa 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
@@ -550,7 +550,7 @@ static void read_edp_current_link_settings_on_detect(struct dc_link *link)
-		udelay(8000);
+		msleep(8);
 	ASSERT(status == DC_OK);

amd-gfx mailing list
amd-gfx at lists.freedesktop.org

More information about the amd-gfx mailing list