[PATCH xf86-video-ati] Revert "glamor: Avoid glamor_create_pixmap for pixmaps backing windows"

Deucher, Alexander Alexander.Deucher at amd.com
Fri Mar 8 17:19:28 UTC 2019


Acked-by: Alex Deucher <alexander.deucher at amd.com>
________________________________
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> on behalf of Michel Dänzer <michel at daenzer.net>
Sent: Friday, March 8, 2019 5:51 AM
To: amd-gfx at lists.freedesktop.org
Subject: [PATCH xf86-video-ati] Revert "glamor: Avoid glamor_create_pixmap for pixmaps backing windows"

From: Michel Dänzer <michel.daenzer at amd.com>

This reverts commit 274703087f80342f51fa69c935bb9a1cb0c4ae47.

Reports of visual corruption were bisected to this, e.g.
https://bugs.archlinux.org/task/61941 . I can reproduce this with Turks,
but not with Bonaire. I assume it's a Mesa/glamor bug, but let's revert
for now.

Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
---
 src/radeon_glamor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/radeon_glamor.c b/src/radeon_glamor.c
index 3e676f2dc..f1098381e 100644
--- a/src/radeon_glamor.c
+++ b/src/radeon_glamor.c
@@ -238,7 +238,7 @@ radeon_glamor_create_pixmap(ScreenPtr screen, int w, int h, int depth,
                 if (info->shadow_primary) {
                         if (usage != CREATE_PIXMAP_USAGE_BACKING_PIXMAP)
                                 return fbCreatePixmap(screen, w, h, depth, usage);
-               } else if (usage != CREATE_PIXMAP_USAGE_BACKING_PIXMAP) {
+               } else {
                         pixmap = glamor_create_pixmap(screen, w, h, depth, usage);
                         if (pixmap)
                             return pixmap;
--
2.20.1

_______________________________________________
amd-gfx mailing list
amd-gfx at lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20190308/03bbf594/attachment-0001.html>


More information about the amd-gfx mailing list