[patch] ras fix patch set

[Pan, Xinhui]

It is sysfs_attr_init() that set the attribute->key to a static variable.
I think the proper fix should just call sysfs_attr_init for each attribute.

Thanks
xinhui

-----Original Message-----
From: Michel Dänzer <michel at daenzer.net> 
Sent: 2019年3月11日 18:42
To: Pan, Xinhui <Xinhui.Pan at amd.com>
Cc: amd-gfx at lists.freedesktop.org; Deucher, Alexander <Alexander.Deucher at amd.com>; Xu, Feifei <Feifei.Xu at amd.com>; Quan, Evan <Evan.Quan at amd.com>; Zhang, Hawking <Hawking.Zhang at amd.com>
Subject: Re: [patch] ras fix patch set

On 2019-03-11 8:35 a.m., Pan, Xinhui wrote:
> Hi
> This is to fix some issues.

Please send patches as individual e-mails with git send-email, not as attachments.


> 2) lockdep warning.

No other sysfs_create_group caller under drivers/gpu/drm/ uses ignore_lockdep, so that smells like a workaround rather than a proper fix. Looking at drivers/gpu/drm/amd/amdkfd/kfd_topology.c:kfd_build_sysfs_node_entry(),
maybe struct attribute(_group) need to be stored in allocated memory instead of on the stack?

P.S. Some lines added by your patches aren't indented correctly. Make sure your editor is properly configured for the Linux kernel coding style.

-- 
Earthling Michel Dänzer               |              https://www.amd.com
Libre software enthusiast             |             Mesa and X developer