[patch] ras fix patch set

Michel Dänzer michel at daenzer.net
Mon Mar 11 10:42:03 UTC 2019


On 2019-03-11 8:35 a.m., Pan, Xinhui wrote:
> Hi
> This is to fix some issues.

Please send patches as individual e-mails with git send-email, not as
attachments.


> 2) lockdep warning.

No other sysfs_create_group caller under drivers/gpu/drm/ uses
ignore_lockdep, so that smells like a workaround rather than a proper
fix. Looking at
drivers/gpu/drm/amd/amdkfd/kfd_topology.c:kfd_build_sysfs_node_entry(),
maybe struct attribute(_group) need to be stored in allocated memory
instead of on the stack?


P.S. Some lines added by your patches aren't indented correctly. Make
sure your editor is properly configured for the Linux kernel coding style.

-- 
Earthling Michel Dänzer               |              https://www.amd.com
Libre software enthusiast             |             Mesa and X developer


More information about the amd-gfx mailing list