[PATCH] drm/amd/powerplay: check for invalid profile mode before switching

[Deucher, Alexander]

Sure no problem.

Acked-by: Alex Deucher <alexander.deucher at amd.com>
________________________________
From: Quan, Evan
Sent: Wednesday, March 27, 2019 9:55 PM
To: Quan, Evan; amd-gfx at lists.freedesktop.org; Deucher, Alexander
Cc: Russell, Kent
Subject: RE: [PATCH] drm/amd/powerplay: check for invalid profile mode before switching

It's kind of an improvement of the previous commit
    drm/amd/powerplay: update current profile mode only when it's really applied

    No need to update current profile mode if the new profile mode
    does not take effect in fact.

Maybe @Deucher, Alexander can help to combine them as one.

Regards,
Evan
> -----Original Message-----
> From: Evan Quan <evan.quan at amd.com>
> Sent: Thursday, March 28, 2019 9:51 AM
> To: amd-gfx at lists.freedesktop.org
> Cc: Russell, Kent <Kent.Russell at amd.com>; Quan, Evan
> <Evan.Quan at amd.com>
> Subject: [PATCH] drm/amd/powerplay: check for invalid profile mode before
> switching
>
> Need to check for invalid profile mode settings before determining to switch
> to that.
>
> Change-Id: Ie47cd75a73a8369c349410ea74d322df1d3d38d1
> Signed-off-by: Evan Quan <evan.quan at amd.com>
> ---
>  drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> index 85a536924571..973a8896fa9d 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> @@ -4906,9 +4906,6 @@ static int vega10_set_power_profile_mode(struct
> pp_hwmgr *hwmgr, long *input, ui
>        uint8_t min_active_level;
>        uint32_t power_profile_mode = input[size];
>
> -     smum_send_msg_to_smc_with_parameter(hwmgr,
> PPSMC_MSG_SetWorkloadMask,
> -                                             1 << power_profile_mode);
> -
>        if (power_profile_mode == PP_SMC_POWER_PROFILE_CUSTOM) {
>                if (size == 0 || size > 4)
>                        return -EINVAL;
> @@ -4923,6 +4920,8 @@ static int vega10_set_power_profile_mode(struct
> pp_hwmgr *hwmgr, long *input, ui
>                                        use_rlc_busy << 16 |
> min_active_level<<24);
>        }
>
> +     smum_send_msg_to_smc_with_parameter(hwmgr,
> PPSMC_MSG_SetWorkloadMask,
> +                                             1 << power_profile_mode);
>        hwmgr->power_profile_mode = power_profile_mode;
>
>        return 0;
> --
> 2.21.0

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20190328/1564f360/attachment.html>