[PATCH] drm/amdgpu/sdma5: fix mask value of POLL_REGMEM packet for pipe sync

Michel Dänzer michel at daenzer.net
Thu Oct 10 16:45:32 UTC 2019


On 2019-10-09 7:09 p.m., Yuan, Xiaojie wrote:
> sdma will hang once sequence number to be polled reaches 0x1000_0000
> 
> Signed-off-by: Xiaojie Yuan <xiaojie.yuan at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c
> index ad5c3566337c..3460c00f3eaa 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c
> @@ -1126,7 +1126,7 @@ static void sdma_v5_0_ring_emit_pipeline_sync(struct amdgpu_ring *ring)
>   	amdgpu_ring_write(ring, addr & 0xfffffffc);
>   	amdgpu_ring_write(ring, upper_32_bits(addr) & 0xffffffff);
>   	amdgpu_ring_write(ring, seq); /* reference */
> -	amdgpu_ring_write(ring, 0xfffffff); /* mask */
> +	amdgpu_ring_write(ring, 0xffffffff); /* mask */

How about ~0u instead?


-- 
Earthling Michel Dänzer               |               https://redhat.com
Libre software enthusiast             |             Mesa and X developer


More information about the amd-gfx mailing list