[PATCH] drm/amdgpu/sdma5: fix mask value of POLL_REGMEM packet for pipe sync

[Christian König]

Good catch! Reviewed-by: Christian König <christian.koenig at amd.com>

Am 09.10.19 um 19:11 schrieb Deucher, Alexander:
> Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
> ------------------------------------------------------------------------
> *From:* amd-gfx <amd-gfx-bounces at lists.freedesktop.org> on behalf of 
> Yuan, Xiaojie <Xiaojie.Yuan at amd.com>
> *Sent:* Wednesday, October 9, 2019 1:09 PM
> *To:* amd-gfx at lists.freedesktop.org <amd-gfx at lists.freedesktop.org>
> *Cc:* Xiao, Jack <Jack.Xiao at amd.com>; Yuan, Xiaojie 
> <Xiaojie.Yuan at amd.com>; Zhang, Hawking <Hawking.Zhang at amd.com>
> *Subject:* [PATCH] drm/amdgpu/sdma5: fix mask value of POLL_REGMEM 
> packet for pipe sync
> sdma will hang once sequence number to be polled reaches 0x1000_0000
>
> Signed-off-by: Xiaojie Yuan <xiaojie.yuan at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c 
> b/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c
> index ad5c3566337c..3460c00f3eaa 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c
> @@ -1126,7 +1126,7 @@ static void 
> sdma_v5_0_ring_emit_pipeline_sync(struct amdgpu_ring *ring)
>          amdgpu_ring_write(ring, addr & 0xfffffffc);
>          amdgpu_ring_write(ring, upper_32_bits(addr) & 0xffffffff);
>          amdgpu_ring_write(ring, seq); /* reference */
> -       amdgpu_ring_write(ring, 0xfffffff); /* mask */
> +       amdgpu_ring_write(ring, 0xffffffff); /* mask */
>          amdgpu_ring_write(ring, 
> SDMA_PKT_POLL_REGMEM_DW5_RETRY_COUNT(0xfff) |
> SDMA_PKT_POLL_REGMEM_DW5_INTERVAL(4)); /* retry count, poll interval */
>  }
> -- 
> 2.20.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20191011/47ebcfdd/attachment-0001.html>