[PATCH] drm/amdgpu: simplify hw status clear/set logic

[Deng, Emily]

Reviewed-by: Emily.Deng <Emily.Deng at amd.com>

>-----Original Message-----
>From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Gu,
>JiaWei (Will)
>Sent: Thursday, August 27, 2020 2:50 PM
>To: amd-gfx at lists.freedesktop.org
>Cc: Gu, JiaWei (Will) <JiaWei.Gu at amd.com>
>Subject: RE: [PATCH] drm/amdgpu: simplify hw status clear/set logic
>
>[AMD Official Use Only - Internal Distribution Only]
>
>Ping...
>
>-----Original Message-----
>From: Jiawei <Jiawei.Gu at amd.com>
>Sent: Thursday, August 27, 2020 10:32 AM
>To: amd-gfx at lists.freedesktop.org
>Cc: Gu, JiaWei (Will) <JiaWei.Gu at amd.com>
>Subject: [PATCH] drm/amdgpu: simplify hw status clear/set logic
>
>Optimize code to iterate less loops in
>amdgpu_device_ip_reinit_early_sriov()
>
>Signed-off-by: Jiawei <Jiawei.Gu at amd.com>
>---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
>diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>index 8f37f9f99105..696a61cc3ac6 100644
>--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>@@ -2598,17 +2598,16 @@ static int
>amdgpu_device_ip_reinit_early_sriov(struct amdgpu_device *adev)
> 		AMD_IP_BLOCK_TYPE_IH,
> 	};
>
>-	for (i = 0; i < adev->num_ip_blocks; i++)
>-		adev->ip_blocks[i].status.hw = false;
>-
>-	for (i = 0; i < ARRAY_SIZE(ip_order); i++) {
>+	for (i = 0; i < adev->num_ip_blocks; i++) {
> 		int j;
> 		struct amdgpu_ip_block *block;
>
>-		for (j = 0; j < adev->num_ip_blocks; j++) {
>-			block = &adev->ip_blocks[j];
>+		block = &adev->ip_blocks[i];
>+		block->status.hw = false;
>
>-			if (block->version->type != ip_order[i] ||
>+		for (j = 0; j < ARRAY_SIZE(ip_order); j++) {
>+
>+			if (block->version->type != ip_order[j] ||
> 				!block->status.valid)
> 				continue;
>
>--
>2.17.1
>_______________________________________________
>amd-gfx mailing list
>amd-gfx at lists.freedesktop.org
>https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.free
>desktop.org%2Fmailman%2Flistinfo%2Famd-
>gfx&data=02%7C01%7CEmily.Deng%40amd.com%7Cd49aeebc6337454ad
>be508d84a558474%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C6
>37341078483894286&sdata=ORgvulljLZNfexMcXZCXi4JEmz3J357Oxa%2B
>GxYW3%2FSo%3D&reserved=0