[PATCH] drm/amdgpu: simplify hw status clear/set logic

[Nirmoy]

On 8/27/20 4:32 AM, Jiawei wrote:
> Optimize code to iterate less loops in
> amdgpu_device_ip_reinit_early_sriov()
>
> Signed-off-by: Jiawei <Jiawei.Gu at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 13 ++++++-------
>   1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 8f37f9f99105..696a61cc3ac6 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -2598,17 +2598,16 @@ static int amdgpu_device_ip_reinit_early_sriov(struct amdgpu_device *adev)
>   		AMD_IP_BLOCK_TYPE_IH,
>   	};
>   
> -	for (i = 0; i < adev->num_ip_blocks; i++)
> -		adev->ip_blocks[i].status.hw = false;
> -
> -	for (i = 0; i < ARRAY_SIZE(ip_order); i++) {
> +	for (i = 0; i < adev->num_ip_blocks; i++) {
>   		int j;
>   		struct amdgpu_ip_block *block;
>   
> -		for (j = 0; j < adev->num_ip_blocks; j++) {
> -			block = &adev->ip_blocks[j];
> +		block = &adev->ip_blocks[i];
> +		block->status.hw = false;
>   
> -			if (block->version->type != ip_order[i] ||
> +		for (j = 0; j < ARRAY_SIZE(ip_order); j++) {


We could probably replace this "for" loop with a big if-statement

     if ( block->version->type== AMD_IP_BLOCK_TYPE_GMC ||

          block->version->type== AMD_IP_BLOCK_TYPE_COMMON ... )


But anyway it looks good to me as it is. Acked-by: Nirmoy Das 
<nirmoy.das at amd.com>

> +
> +			if (block->version->type != ip_order[j] ||
>   				!block->status.valid)
>   				continue;
>