[PATCH] drm/amdgpu: Fix macro name _AMDGPU_TRACE_H_ in preprocessor if condition

Paul Menzel pmenzel at molgen.mpg.de
Sun Dec 27 10:53:12 UTC 2020


Dear Christian,


Am 27.12.20 um 10:38 schrieb Christian König:
> Am 26.12.20 um 14:16 schrieb Paul Menzel:

>> Am 26.12.20 um 09:56 schrieb Chenyang Li:
>>> Add an underscore in amdgpu_trace.h line 24 "_AMDGPU_TRACE_H".
>>>
>>> Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)")
> 
> Well this Fixes tag is superfluous/misleading and should probably be 
> removed.

Why is it misleading?

> Why was that added?

I asked for that, because that is the commit introducing the issue, and 
with that tag it’s  more likely to picked for the stable series.

[…]


Kind regards,

Paul


More information about the amd-gfx mailing list