[PATCH] drm/amdgpu: Fix macro name _AMDGPU_TRACE_H_ in preprocessor if condition

[Christian König]

Am 27.12.20 um 11:53 schrieb Paul Menzel:
> Dear Christian,
>
>
> Am 27.12.20 um 10:38 schrieb Christian König:
>> Am 26.12.20 um 14:16 schrieb Paul Menzel:
>
>>> Am 26.12.20 um 09:56 schrieb Chenyang Li:
>>>> Add an underscore in amdgpu_trace.h line 24 "_AMDGPU_TRACE_H".
>>>>
>>>> Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)")
>>
>> Well this Fixes tag is superfluous/misleading and should probably be 
>> removed.
>
> Why is it misleading?

The purpose of a Fixes tag is to distinct into which stable sources a 
patch should be added.

E.g. if somebody maintains a backport which has the originally buggy 
patch then he can figure out that he needs this one as well.

But since this problem is there for as long as the driver existed that 
is pretty much superfluous and confusing.

>
>> Why was that added?
>
> I asked for that, because that is the commit introducing the issue, 
> and with that tag it’s  more likely to picked for the stable series.

Ah, yes that is a rather good idea. But we should probably use a "CC: 
stable at kernel.org" tag instead since this patch can be added pretty much 
everywhere.

Thanks,
Christian.

>
> […]
>
>
> Kind regards,
>
> Paul