[PATCH 00/12] drm/amdgpu: add register distance

Christian König christian.koenig at amd.com
Mon Jul 6 10:39:32 UTC 2020


Am 06.07.20 um 07:04 schrieb Huang Rui:
> During IP block updates in some asic, the register distribution pattern of
> context domains and invalidation engines will be changed in gc_v***.h and
> mmhub_v***.h. However the register distances are always constant in one IP block
> beside gfxhub and mmhub. So we can add register distance member in vmhub
> structure to store the register distance value, that's able to avoid the issue
> of hardcode at current in future updates.

Reviewed-by: Christian König <christian.koenig at amd.com> for the whole 
series.

>
> Thanks,
> Ray
>
> Huang Rui (12):
>    drm/amdgpu: add register distance members into vmhub structure
>    drm/amdgpu: use register distance member instead of hardcode in GMC9
>    drm/amdgpu: use register distance member instead of hardcode in GMC10
>    drm/amdgpu: use register distance member instead of hardcode in
>      VCN1/JEPG1
>    drm/amdgpu: use register distance member instead of hardcode in
>      UVD7/VCE4
>    drm/amdgpu: use register distance member instead of hardcode in
>      VCN2/JEPG2
>    drm/amdgpu: use register distance member instead of hardcode in gfxhub
>      v1
>    drm/amdgpu: use register distance member instead of hardcode in gfxhub
>      v2
>    drm/amdgpu: use register distance member instead of hardcode in gfxhub
>      v2.1
>    drm/amdgpu: use register distance member instead of hardcode in mmhub
>      v1
>    drm/amdgpu: use register distance member instead of hardcode in mmhub
>      v2
>    drm/amdgpu: use register distance member instead of hardcode in mmhub
>      v9.4
>
>   drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h  |  9 +++++
>   drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c | 48 ++++++++++++++++--------
>   drivers/gpu/drm/amd/amdgpu/gfxhub_v2_0.c | 47 +++++++++++++++--------
>   drivers/gpu/drm/amd/amdgpu/gfxhub_v2_1.c | 47 +++++++++++++++--------
>   drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c   | 43 ++++++++++++---------
>   drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c    | 39 ++++++++++++-------
>   drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.c   |  2 +-
>   drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c   |  2 +-
>   drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c  | 45 ++++++++++++++--------
>   drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c  | 46 +++++++++++++++--------
>   drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c  | 46 +++++++++++++++--------
>   drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c    |  5 ++-
>   drivers/gpu/drm/amd/amdgpu/vce_v4_0.c    |  3 +-
>   drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c    |  5 ++-
>   drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c    |  5 ++-
>   15 files changed, 260 insertions(+), 132 deletions(-)
>



More information about the amd-gfx mailing list