[PATCH] drm/amdgpu: No sysfs, not an error condition

Alex Deucher alexdeucher at gmail.com
Wed Sep 16 19:59:08 UTC 2020


On Wed, Sep 16, 2020 at 1:09 PM Luben Tuikov <luben.tuikov at amd.com> wrote:
>
> Not being able to create amdgpu sysfs attributes
> is not a fatal error warranting not to continue
> to try to bring up the display. Thus, if we get
> an error trying to create amdgpu sysfs attrs,
> report it and continue on to try to bring up
> a display.
>
> Signed-off-by: Luben Tuikov <luben.tuikov at amd.com>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 5d702f6e77de..62174f5e8311 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -3400,10 +3400,8 @@ int amdgpu_device_init(struct amdgpu_device *adev,
>                 flush_delayed_work(&adev->delayed_init_work);
>
>         r = sysfs_create_files(&adev->dev->kobj, amdgpu_dev_attributes);
> -       if (r) {
> +       if (r)
>                 dev_err(adev->dev, "Could not create amdgpu device attr\n");
> -               return r;
> -       }
>
>         if (IS_ENABLED(CONFIG_PERF_EVENTS))
>                 r = amdgpu_pmu_init(adev);
> --
> 2.28.0.394.ge197136389
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list