[PATCH] drm/amdgpu: No sysfs, not an error condition

[Abramov, Slava]

[AMD Official Use Only - Internal Distribution Only]

​Acked-by: Slava Abramov <slava.abramov at amd.com>

________________________________
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> on behalf of Luben Tuikov <luben.tuikov at amd.com>
Sent: Wednesday, September 16, 2020 1:08 PM
To: amd-gfx at lists.freedesktop.org <amd-gfx at lists.freedesktop.org>
Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Tuikov, Luben <Luben.Tuikov at amd.com>
Subject: [PATCH] drm/amdgpu: No sysfs, not an error condition

Not being able to create amdgpu sysfs attributes
is not a fatal error warranting not to continue
to try to bring up the display. Thus, if we get
an error trying to create amdgpu sysfs attrs,
report it and continue on to try to bring up
a display.

Signed-off-by: Luben Tuikov <luben.tuikov at amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 5d702f6e77de..62174f5e8311 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -3400,10 +3400,8 @@ int amdgpu_device_init(struct amdgpu_device *adev,
                 flush_delayed_work(&adev->delayed_init_work);

         r = sysfs_create_files(&adev->dev->kobj, amdgpu_dev_attributes);
-       if (r) {
+       if (r)
                 dev_err(adev->dev, "Could not create amdgpu device attr\n");
-               return r;
-       }

         if (IS_ENABLED(CONFIG_PERF_EVENTS))
                 r = amdgpu_pmu_init(adev);
--
2.28.0.394.ge197136389

_______________________________________________
amd-gfx mailing list
amd-gfx at lists.freedesktop.org
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cslava.abramov%40amd.com%7C08421e1e2e0041c5b71c08d85a633ac5%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637358729546814375&sdata=KOD9dj7ibpXC6s0PiXJFyxWfhdC74zxQkGOIKjcw3EY%3D&reserved=0
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20200916/2a8b8b53/attachment-0001.htm>