[PATCH] drm/amdkfd: Correct the value of the no_atomic_fw_version variable

Sider, Graham Graham.Sider at amd.com
Thu Dec 2 14:16:19 UTC 2021


[AMD Official Use Only]

> From: chen gong <curry.gong at amd.com>
> Sent: Thursday, December 2, 2021 3:56 AM
> To: amd-gfx at lists.freedesktop.org
> Cc: Sider, Graham <Graham.Sider at amd.com>; Gong, Curry
> <Curry.Gong at amd.com>
> Subject: [PATCH] drm/amdkfd: Correct the value of the
> no_atomic_fw_version variable
> 
> 145:
> navi10            IP_VERSION(10, 1, 10)
> navi12            IP_VERSION(10, 1, 2)
> navi14            IP_VERSION(10, 1, 1)
> 
> 92:
> sienna_cichlid    IP_VERSION(10, 3, 0)
> navy_flounder     IP_VERSION(10, 3, 2)
> vangogh           IP_VERSION(10, 3, 1)
> dimgrey_cavefish  IP_VERSION(10, 3, 4)
> beige_goby        IP_VERSION(10, 3, 5)
> yellow_carp       IP_VERSION(10, 3, 3)
> 
> Signed-off-by: chen gong <curry.gong at amd.com>

Good catch, these were mistakenly reversed. Thanks!

Reviewed-by: Graham Sider <Graham.Sider at amd.com>

> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_device.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> index e6fded7..267668b 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> @@ -94,9 +94,9 @@ static void kfd_device_info_init(struct kfd_dev *kfd,
>  		if (gc_version < IP_VERSION(11, 0, 0)) {
>  			/* Navi2x+, Navi1x+ */
>  			if (gc_version >= IP_VERSION(10, 3, 0))
> -				kfd->device_info.no_atomic_fw_version =
> 145;
> -			else if (gc_version >= IP_VERSION(10, 1, 1))
>  				kfd->device_info.no_atomic_fw_version =
> 92;
> +			else if (gc_version >= IP_VERSION(10, 1, 1))
> +				kfd->device_info.no_atomic_fw_version =
> 145;
> 
>  			/* Navi1x+ */
>  			if (gc_version >= IP_VERSION(10, 1, 1))
> --
> 2.7.4


More information about the amd-gfx mailing list