[PATCH] drm/amd/display: fix a missing prototype warning in DCN303

[Pillai, Aurabindo]

[AMD Official Use Only]

Hi Siqueira,

Thanks for the heads up, lets apply Isabella's patch instead.

--

Regards,
Jay
________________________________
From: Siqueira, Rodrigo <Rodrigo.Siqueira at amd.com>
Sent: Wednesday, December 8, 2021 10:17 AM
To: Pillai, Aurabindo <Aurabindo.Pillai at amd.com>; amd-gfx at lists.freedesktop.org <amd-gfx at lists.freedesktop.org>; Isabella Basso <isabbasso at riseup.net>
Cc: Wentland, Harry <Harry.Wentland at amd.com>; Siqueira, Rodrigo <Rodrigo.Siqueira at amd.com>; kernel test robot <lkp at intel.com>
Subject: Re: [PATCH] drm/amd/display: fix a missing prototype warning in DCN303



On 2021-12-07 2:18 p.m., Aurabindo Pillai wrote:
> [Why&How]
> A missing include statement triggered a warning when running
> a build with W=1:
>
>>> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn303/dcn303_init.c:30:6: warning: no previous prototype for 'dcn303_hw_sequencer_construct' [-Wmissing-prototypes]
>        30 | void dcn303_hw_sequencer_construct(struct dc *dc)
>           |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Fixes: cd6d421e3d1a (drm/amd/display: Initial DC support for Beige Goby)
> Reported-by: kernel test robot <lkp at intel.com>
> Signed-off-by: Aurabindo Pillai <aurabindo.pillai at amd.com>
> ---
>   drivers/gpu/drm/amd/display/dc/dcn303/dcn303_init.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn303/dcn303_init.c b/drivers/gpu/drm/amd/display/dc/dcn303/dcn303_init.c
> index aa5dbbade2bd..d59b24a972bc 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn303/dcn303_init.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn303/dcn303_init.c
> @@ -7,6 +7,7 @@
>
>   #include "dcn303_hwseq.h"
>   #include "dcn30/dcn30_init.h"
> +#include "dcn303_init.h"
>   #include "dc.h"
>
>   void dcn303_hw_sequencer_construct(struct dc *dc)
>

Hi Jay,

Isabella made the below patch that fixes this issue in multiple files:

  https://patchwork.freedesktop.org/patch/465821/?series=97701&rev=1

Maybe we can go ahead with Isabella's patch?

Thanks
Siqueira
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20211208/4f1dda78/attachment.htm>