[PATCH -next] drm/radeon: Add the missed drm_gem_object_put() in radeon_user_framebuffer_create()
Christian König
christian.koenig at amd.com
Tue Jun 29 11:42:18 UTC 2021
Am 29.06.21 um 13:44 schrieb Jing Xiangfeng:
> radeon_user_framebuffer_create() misses to call drm_gem_object_put() in
> an error path. Add the missed function call to fix it.
>
> Signed-off-by: Jing Xiangfeng <jingxiangfeng at huawei.com>
I'm pretty sure that I already reviewed the same patch a few weeks ago,
but it looks like it never went upstream.
Reviewed-by: Christian König <christian.koenig at amd.com>
Maybe add CC: stable as well?
Regards,
Christian.
> ---
> drivers/gpu/drm/radeon/radeon_display.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
> index 652af7a134bd..1d03ec763604 100644
> --- a/drivers/gpu/drm/radeon/radeon_display.c
> +++ b/drivers/gpu/drm/radeon/radeon_display.c
> @@ -1325,6 +1325,7 @@ radeon_user_framebuffer_create(struct drm_device *dev,
> /* Handle is imported dma-buf, so cannot be migrated to VRAM for scanout */
> if (obj->import_attach) {
> DRM_DEBUG_KMS("Cannot create framebuffer from imported dma_buf\n");
> + drm_gem_object_put(obj);
> return ERR_PTR(-EINVAL);
> }
>
More information about the amd-gfx
mailing list