[PATCH] drm/amdgpu: Make noretry the default on yellow carp

Huang, Ray Ray.Huang at amd.com
Wed Jun 30 06:00:04 UTC 2021

[AMD Official Use Only]

Reviewed-by: Huang Rui <ray.huang at amd.com>

-----Original Message-----
From: Liu, Aaron <Aaron.Liu at amd.com> 
Sent: Wednesday, June 30, 2021 1:57 PM
To: amd-gfx at lists.freedesktop.org
Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Huang, Ray <Ray.Huang at amd.com>; Gong, Curry <Curry.Gong at amd.com>; Kuehling, Felix <Felix.Kuehling at amd.com>; Liu, Aaron <Aaron.Liu at amd.com>; Huang, Ray <Ray.Huang at amd.com>
Subject: [PATCH] drm/amdgpu: Make noretry the default on yellow carp

From: chen gong <curry.gong at amd.com>

Performing kfd page fault tests on the yellow carp platform will fail.

>From the scan data after the failure, it can be found that a nack=0x1(retry fault) is returned. but we did not enable the interrupts for retry faults in the code.

So we need to set noretry = 1 like the above ASICs.

Signed-off-by: chen gong <curry.gong at amd.com>
Reviewed-by: Aaron Liu <aaron.liu at amd.com>
Acked-by: Huang Rui <ray.huang at amd.com>
 drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
index 1525d957e114..d4e9704dec62 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
@@ -591,6 +591,7 @@ void amdgpu_gmc_noretry_set(struct amdgpu_device *adev)
 		 * noretry = 0 will cause kfd page fault tests fail
 		 * for some ASICs, so set default to 1 for these ASICs.

More information about the amd-gfx mailing list