[PATCH 2/2] drm/amdgpu: skip query VFCT table for headless ASICs

[Alex Deucher]

On Tue, Mar 9, 2021 at 11:38 PM Feifei Xu <Feifei.Xu at amd.com> wrote:
>
> There will be no GOP driver to copy vbios image to
> VFCT table for headless ASICs. Thus skip VFCT.

I'm not sure these patches are entirely correct.

>
> Signed-off-by: Feifei Xu <Feifei.Xu at amd.com>
> Reviewed-by: Hawking Zhang <Hawking.Zhang at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
> index f454a6bd0ed6..03739774beca 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
> @@ -427,7 +427,7 @@ bool amdgpu_get_bios(struct amdgpu_device *adev)
>                 goto success;
>         }
>
> -       if (amdgpu_acpi_vfct_bios(adev)) {
> +       if (!amdgpu_device_is_headless(adev) && amdgpu_acpi_vfct_bios(adev)) {

I would drop the first patch and just check the pci class directly
here, it's more clear what it's checking for, plus I don't know if
it's a good idea to mix the nv check in here.

Alex

>                 dev_info(adev->dev, "Fetched VBIOS from VFCT\n");
>                 goto success;
>         }
> --
> 2.25.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx