[PATCH 2/2] drm/amdgpu: skip query VFCT table for headless ASICs

[Xu, Feifei]

[AMD Official Use Only - Internal Distribution Only]

Hi Alex,
Hi Alex

We have a thread discussed the GOP driver with Xiong on headless SKUs. Just forwarded that to you as well. He has confirmed this on that thread.

There's some NV ASICs which have VCN harvested. Those parts have the VGA class while it is headless.
I am thinking to centralize the non-VGA subclass devices and VGA subclass but headless devices. So added the amdgpu_device_is_headless() function including NV check.

I can drop the amdgpu_device_is_headless(). And check the headless case by checking both VGA subclass and nv_is_headless().

Thanks,
Feifei

-----Original Message-----
From: Alex Deucher <alexdeucher at gmail.com>
Sent: Wednesday, March 10, 2021 12:50 PM
To: Xu, Feifei <Feifei.Xu at amd.com>
Cc: amd-gfx list <amd-gfx at lists.freedesktop.org>; Zhang, Hawking <Hawking.Zhang at amd.com>
Subject: Re: [PATCH 2/2] drm/amdgpu: skip query VFCT table for headless ASICs

On Tue, Mar 9, 2021 at 11:38 PM Feifei Xu <Feifei.Xu at amd.com> wrote:
>
> There will be no GOP driver to copy vbios image to VFCT table for
> headless ASICs. Thus skip VFCT.

I'm not sure these patches are entirely correct.

>
> Signed-off-by: Feifei Xu <Feifei.Xu at amd.com>
> Reviewed-by: Hawking Zhang <Hawking.Zhang at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
> index f454a6bd0ed6..03739774beca 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
> @@ -427,7 +427,7 @@ bool amdgpu_get_bios(struct amdgpu_device *adev)
>                 goto success;
>         }
>
> -       if (amdgpu_acpi_vfct_bios(adev)) {
> +       if (!amdgpu_device_is_headless(adev) &&
> + amdgpu_acpi_vfct_bios(adev)) {

I would drop the first patch and just check the pci class directly here, it's more clear what it's checking for, plus I don't know if it's a good idea to mix the nv check in here.

Alex

>                 dev_info(adev->dev, "Fetched VBIOS from VFCT\n");
>                 goto success;
>         }
> --
> 2.25.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist
> s.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7CFe
> ifei.Xu%40amd.com%7C298d17c750fe4fc8529a08d8e380098f%7C3dd8961fe4884e6
> 08e11a82d994e183d%7C0%7C0%7C637509486351235872%7CUnknown%7CTWFpbGZsb3d
> 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C
> 1000&sdata=MGfjf7kaF8bILyrllz7Dd9hSiKSMRrbswvDjAB7u%2BN4%3D&re
> served=0