[PATCH] drm/ttm: Put BO in its memory manager's lru list

Christian König christian.koenig at amd.com
Tue Nov 9 12:20:50 UTC 2021


Am 09.11.21 um 12:19 schrieb xinhui pan:
> After we move BO to a new memory region, we should put it to
> the new memory manager's lru list regardless we unlock the resv or not.
>
> Signed-off-by: xinhui pan <xinhui.pan at amd.com>

Interesting find, did you trigger that somehow or did you just stumbled 
over it by reading the code?

Patch is Reviewed-by: Christian König <christian.koenig at amd.com>, I will 
pick that up for drm-misc-next.

Thanks,
Christian.

> ---
>   drivers/gpu/drm/ttm/ttm_bo.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index f1367107925b..e307004f0b28 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -701,6 +701,8 @@ int ttm_mem_evict_first(struct ttm_device *bdev,
>   	ret = ttm_bo_evict(bo, ctx);
>   	if (locked)
>   		ttm_bo_unreserve(bo);
> +	else
> +		ttm_bo_move_to_lru_tail_unlocked(bo);
>   
>   	ttm_bo_put(bo);
>   	return ret;



More information about the amd-gfx mailing list