回复: [PATCH] drm/ttm: Put BO in its memory manager's lru list

[Pan, Xinhui]

[AMD Official Use Only]

I hit vulkan cts test hang with navi23.

dmesg says gmc page fault with address 0x0, 0x1000, 0x2000....
And some debug log also says amdgu copy one BO from system Domain to system Domain which is really weird.
________________________________________
发件人: Koenig, Christian <Christian.Koenig at amd.com>
发送时间: 2021年11月9日 20:20
收件人: Pan, Xinhui; amd-gfx at lists.freedesktop.org
抄送: dri-devel at lists.freedesktop.org
主题: Re: [PATCH] drm/ttm: Put BO in its memory manager's lru list

Am 09.11.21 um 12:19 schrieb xinhui pan:
> After we move BO to a new memory region, we should put it to
> the new memory manager's lru list regardless we unlock the resv or not.
>
> Signed-off-by: xinhui pan <xinhui.pan at amd.com>

Interesting find, did you trigger that somehow or did you just stumbled
over it by reading the code?

Patch is Reviewed-by: Christian König <christian.koenig at amd.com>, I will
pick that up for drm-misc-next.

Thanks,
Christian.

> ---
>   drivers/gpu/drm/ttm/ttm_bo.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index f1367107925b..e307004f0b28 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -701,6 +701,8 @@ int ttm_mem_evict_first(struct ttm_device *bdev,
>       ret = ttm_bo_evict(bo, ctx);
>       if (locked)
>               ttm_bo_unreserve(bo);
> +     else
> +             ttm_bo_move_to_lru_tail_unlocked(bo);
>
>       ttm_bo_put(bo);
>       return ret;