[PATCH] drm/amd/amdgpu: use advanced TDR mode by default

[Wang, Yang(Kevin)]

[AMD Official Use Only]

although this module parameter can be modified during driver probe, but it also can be modified at runtime.
(via /sys/module/amdgpu/parameter/gpu_recovery).
This may result in a mismatch with the expected results.
You'd better to check SRIOV in the right place.

Best Regards,
Kevin
________________________________
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> on behalf of Bokun Zhang <Bokun.Zhang at amd.com>
Sent: Saturday, November 27, 2021 8:57 AM
To: amd-gfx at lists.freedesktop.org <amd-gfx at lists.freedesktop.org>
Cc: Zhang, Bokun <Bokun.Zhang at amd.com>
Subject: [PATCH] drm/amd/amdgpu: use advanced TDR mode by default

From: Bokun Zhang <bokun.zhang at amd.com>

In the patch about advanced TDR mode, we force to always set
amdgpu_gpu_recovery=2 under SRIOV. This is not ideal, since we
may want to revert back to use the legacy TDR routine.

Therefore, we only set amdgpu_gpu_recovery=2 when it is
configured as AUTO, which is the default value (gpu_recovery=-1)

Signed-off-by: Bokun Zhang <bokun.zhang at amd.com>
Change-Id: Ifae78854b53f124d2ea53f401919ab5e403ef822
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
index 93af2cd2a065..62ec484a35aa 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
@@ -64,8 +64,8 @@ void amdgpu_virt_init_setting(struct amdgpu_device *adev)
         adev->cg_flags = 0;
         adev->pg_flags = 0;

-       /*use advance recovery mode for SRIOV*/
-       if (amdgpu_gpu_recovery)
+       /* use advance recovery mode for SRIOV by default */
+       if (amdgpu_gpu_recovery == -1)
                 amdgpu_gpu_recovery = 2;
 }

--
2.25.1

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20211128/fa970e0f/attachment.htm>