[PATCH 0/5] Remove 0 MHz as a valid current frequency (v4)

Luben Tuikov luben.tuikov at amd.com
Tue Oct 19 07:43:52 UTC 2021


On 2021-10-19 03:23, Paul Menzel wrote:
> Dear Luben,
>
>
> Sorry, two more style nits.
>
> 1.  Could you please use 75 characters per line for the text width of 
> the commit messages. Currently, especially 4/5, are hard to read being 
> so short.

This is the default we use--I've not made any changes to the wrap. git-log(1) indents the text by 4/8 chars and it looks better if the text doesn't roll past 75 chars per line in git-log.
>
> 2.  No idea, what is done in amd-gfx, but for me it is more common to 
> put the iteration number (reroll count) in the PATCH tag in the 
> beginning. No idea, how Patchwork deals with it.

This is what we do in amd-gfx and particularly in amdgpu, so that the version of the patch is recorded in the title of the patch and in history.

Regards,
Luben

>
>
> Kind regards,
>
> Paul



More information about the amd-gfx mailing list