[PATCH 0/5] Remove 0 MHz as a valid current frequency (v4)

[Paul Menzel]

Dear Luben,


Thank you for your quick reply.

Am 19.10.21 um 09:43 schrieb Luben Tuikov:
> On 2021-10-19 03:23, Paul Menzel wrote:

>> Sorry, two more style nits.
>>
>> 1.  Could you please use 75 characters per line for the text width of
>> the commit messages. Currently, especially 4/5, are hard to read being
>> so short.
> 
> This is the default we use--I've not made any changes to the wrap.

What do you mean? Your editor wraps the lines at the point, where you 
configured it, doesn’t it?

> git-log(1) indents the text by 4/8 chars and it looks better if the
> text doesn't roll past 75 chars per line in git-log.
Patch 4/5 uses a text width of 50 characters, which is too short. From 
commit 2a076f40d8c9 (checkpatch, SubmittingPatches: suggest line 
wrapping commit messages at 75 columns) [1], which added a check for too 
long lines:

> Suggest line wrapping at 75 columns so the default git commit log
> indentation of 4 plus the commit message text still fits on an 80 column
> screen.


>> 2.  No idea, what is done in amd-gfx, but for me it is more common to
>> put the iteration number (reroll count) in the PATCH tag in the
>> beginning. No idea, how Patchwork deals with it.
> 
> This is what we do in amd-gfx and particularly in amdgpu, so that the
> version of the patch is recorded in the title of the patch and in history.
I forgot. Thank you.


Kind regards,

Paul


[1]: 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2a076f40d8c9be95bee7bcf18436655e1140447f