[PATCH] drm/amdgpu: skip GPRs init for some CU settings on ALDEBARAN

Zhou1, Tao Tao.Zhou1 at amd.com
Mon Oct 25 10:25:04 UTC 2021


[AMD Official Use Only]

Thanks, will and comment as you suggested.

Regards,
Tao
________________________________
From: Zhang, Hawking <Hawking.Zhang at amd.com>
Sent: Monday, October 25, 2021 5:29 PM
To: Zhou1, Tao <Tao.Zhou1 at amd.com>; amd-gfx at lists.freedesktop.org <amd-gfx at lists.freedesktop.org>
Subject: RE: [PATCH] drm/amdgpu: skip GPRs init for some CU settings on ALDEBARAN

[AMD Official Use Only]

Please add inline comment to remind us remove this workaround later. Other than the patch is

Reviewed-by: Hawking Zhang <Hawking.Zhang at amd.com>

Regards,
Hawking

-----Original Message-----
From: Zhou1, Tao <Tao.Zhou1 at amd.com>
Sent: Monday, October 25, 2021 16:56
To: amd-gfx at lists.freedesktop.org; Zhang, Hawking <Hawking.Zhang at amd.com>
Cc: Zhou1, Tao <Tao.Zhou1 at amd.com>
Subject: [PATCH] drm/amdgpu: skip GPRs init for some CU settings on ALDEBARAN

Skip GPRs init in specific condition since current GPRs init algorithm only works for some CU settings.

Signed-off-by: Tao Zhou <tao.zhou1 at amd.com>
---
 drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c
index 00a2b36a24b3..a1f424e2ff5f 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c
@@ -706,6 +706,10 @@ int gfx_v9_4_2_do_edc_gpr_workarounds(struct amdgpu_device *adev)
         if (!amdgpu_ras_is_supported(adev, AMDGPU_RAS_BLOCK__GFX))
                 return 0;

+       /* workaround for some CU settings, skip GPRs init */
+       if (adev->gfx.cu_info.bitmap[1][1] == 0x3f7f)
+               return 0;
+
         gfx_v9_4_2_do_sgprs_init(adev);

         gfx_v9_4_2_do_vgprs_init(adev);
--
2.17.1
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20211025/0a686863/attachment.htm>


More information about the amd-gfx mailing list