[bug report] drm/amd/display: use FB pitch to fill dc_cursor_attributes
Simon Ser
contact at emersion.fr
Tue Jul 26 17:16:33 UTC 2022
On Tuesday, July 26th, 2022 at 17:47, Dan Carpenter <dan.carpenter at oracle.com> wrote:
> On Tue, Jul 26, 2022 at 03:27:54PM +0000, Simon Ser wrote:
>
> > plane->state->fb is NULL iff afb is NULL. There is an early return to
> > make sure the dereferences don't cause a segfault.
>
>
> Are you talking about this:
>
> if (!plane->state->fb && !old_plane_state->fb)
>
> return;
>
> Should the && be ||?
Ah, sorry, the reason why this doesn't segfault is different:
get_cursor_position() will leave position.enable = false if there is no
FB, and we have an early return for that. This also guards crtc_state.
More information about the amd-gfx
mailing list