[PATCH 09/10] drm/amdgpu: add gang submit backend

Andrey Grodzovsky andrey.grodzovsky at amd.com
Mon Mar 7 16:02:10 UTC 2022


:)))))

I am like - I must be crazy because no way this works but you insist 
that it is and I know u are usually right.

Andrey

On 2022-03-07 10:59, Christian König wrote:
>>>
>>> If we don't check for NULL here we would just crash.
>>
>>
>> But you go into the 'if clause' if job->gang_submit is equal to NULL, 
>> i would expect to see here
>> if (!fence &&*job->gang_submit*) because you want to switch to an 
>> actual new gang (not to NULL)
>>
>
> WTF? I'm like 100% that I've fixed that before sending it out.
>
> Thanks for point it out, but yeah I've already stumbled over that typo 
> as well.
>
> Christian.
>
>> Andrey
>>
>>
>>>
>>> Christian.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20220307/73bdaaa4/attachment.htm>


More information about the amd-gfx mailing list