[PATCH v2] drm/amd/display: fix indentation in commit_planes_for_stream()

Deucher, Alexander Alexander.Deucher at amd.com
Thu Sep 1 14:38:22 UTC 2022


[Public]

Acked-by: Alex Deucher <alexander.deucher at amd.com>
________________________________
From: Mahfooz, Hamza <Hamza.Mahfooz at amd.com>
Sent: Thursday, September 1, 2022 10:15 AM
To: linux-kernel at vger.kernel.org <linux-kernel at vger.kernel.org>
Cc: Mahfooz, Hamza <Hamza.Mahfooz at amd.com>; Wentland, Harry <Harry.Wentland at amd.com>; Li, Sun peng (Leo) <Sunpeng.Li at amd.com>; Siqueira, Rodrigo <Rodrigo.Siqueira at amd.com>; Deucher, Alexander <Alexander.Deucher at amd.com>; Koenig, Christian <Christian.Koenig at amd.com>; Pan, Xinhui <Xinhui.Pan at amd.com>; David Airlie <airlied at linux.ie>; Daniel Vetter <daniel at ffwll.ch>; Kazlauskas, Nicholas <Nicholas.Kazlauskas at amd.com>; Lei, Jun <Jun.Lei at amd.com>; Somasundaram, Meenakshikumar <Meenakshikumar.Somasundaram at amd.com>; Lee, Alvin <Alvin.Lee2 at amd.com>; Leung, Martin <Martin.Leung at amd.com>; Tam, Samson <Samson.Tam at amd.com>; Hung, Alex <Alex.Hung at amd.com>; Liu, Wenjing <Wenjing.Liu at amd.com>; Aberback, Joshua <Joshua.Aberback at amd.com>; amd-gfx at lists.freedesktop.org <amd-gfx at lists.freedesktop.org>; dri-devel at lists.freedesktop.org <dri-devel at lists.freedesktop.org>
Subject: [PATCH v2] drm/amd/display: fix indentation in commit_planes_for_stream()

Address the following warning:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3508:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
 3508 |         if (update_type != UPDATE_TYPE_FAST)
      |         ^~
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3510:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
 3510 |                 if (update_type != UPDATE_TYPE_FAST)
      |                 ^~

Signed-off-by: Hamza Mahfooz <hamza.mahfooz at amd.com>
---
v2: implement feedback from Alvin
---
 drivers/gpu/drm/amd/display/dc/core/dc.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
index b49237390cce..9860bf38c547 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
@@ -3507,9 +3507,10 @@ static void commit_planes_for_stream(struct dc *dc,

         if (update_type != UPDATE_TYPE_FAST)
                 dc->hwss.post_unlock_program_front_end(dc, context);
-               if (update_type != UPDATE_TYPE_FAST)
-                       if (dc->hwss.commit_subvp_config)
-                               dc->hwss.commit_subvp_config(dc, context);
+
+       if (update_type != UPDATE_TYPE_FAST)
+               if (dc->hwss.commit_subvp_config)
+                       dc->hwss.commit_subvp_config(dc, context);

         /* Since phantom pipe programming is moved to post_unlock_program_front_end,
          * move the SubVP lock to after the phantom pipes have been setup
--
2.37.2

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20220901/c561ca41/attachment.htm>


More information about the amd-gfx mailing list