[PATCH] drm/amdgpu: Rely on MCUMC_STATUS for umc v8_10 correctable error counter only

[Zhang, Hawking]

[AMD Official Use Only - General]

Reviewed-by: Hawking Zhang <Hawking.Zhang at amd.com>

Regards,
Hawking
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> on behalf of Candice Li <Candice.Li at amd.com>
Date: Thursday, September 8, 2022 at 09:15
To: amd-gfx at lists.freedesktop.org <amd-gfx at lists.freedesktop.org>
Cc: Li, Candice <Candice.Li at amd.com>
Subject: [PATCH] drm/amdgpu: Rely on MCUMC_STATUS for umc v8_10 correctable error counter only
Only check MCUMC_STATUS for CE counter for umc v8_10.

Signed-off-by: Candice Li <candice.li at amd.com>
---
 drivers/gpu/drm/amd/amdgpu/umc_v8_10.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/umc_v8_10.c b/drivers/gpu/drm/amd/amdgpu/umc_v8_10.c
index 36a2053f2e8b94..a8cbda81828daf 100644
--- a/drivers/gpu/drm/amd/amdgpu/umc_v8_10.c
+++ b/drivers/gpu/drm/amd/amdgpu/umc_v8_10.c
@@ -101,22 +101,16 @@ static void umc_v8_10_query_correctable_error_count(struct amdgpu_device *adev,
                                                    uint32_t umc_reg_offset,
                                                    unsigned long *error_count)
 {
-       uint32_t ecc_err_cnt, ecc_err_cnt_addr;
         uint64_t mc_umc_status;
         uint32_t mc_umc_status_addr;

         /* UMC 8_10 registers */
-       ecc_err_cnt_addr =
-               SOC15_REG_OFFSET(UMC, 0, regUMCCH0_0_GeccErrCnt);
         mc_umc_status_addr =
                 SOC15_REG_OFFSET(UMC, 0, regMCA_UMC_UMC0_MCUMC_STATUST0);

-       ecc_err_cnt = RREG32_PCIE((ecc_err_cnt_addr + umc_reg_offset) * 4);
-       *error_count +=
-               (REG_GET_FIELD(ecc_err_cnt, UMCCH0_0_GeccErrCnt, GeccErrCnt) -
-                UMC_V8_10_CE_CNT_INIT);
-
-       /* Check for SRAM correctable error, MCUMC_STATUS is a 64 bit register */
+       /* Rely on MCUMC_STATUS for correctable error counter
+        * MCUMC_STATUS is a 64 bit register
+        */
         mc_umc_status = RREG64_PCIE((mc_umc_status_addr + umc_reg_offset) * 4);
         if (REG_GET_FIELD(mc_umc_status, MCA_UMC_UMC0_MCUMC_STATUST0, Val) == 1 &&
             REG_GET_FIELD(mc_umc_status, MCA_UMC_UMC0_MCUMC_STATUST0, CECC) == 1)
--
2.17.1
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20220908/2f658447/attachment.htm>