[PATCH v3 3/4] amd/display: add cursor rotation check

[Simon Ser]

On Thursday, August 17th, 2023 at 15:46, Harry Wentland <harry.wentland at amd.com> wrote:

> On 2023-08-17 09:44, Harry Wentland wrote:
> 
> > On 2023-08-17 06:53, Simon Ser wrote:
> > 
> > > The commit 1347385fe187 ("drm/amd/display: don't expose rotation
> > > prop for cursor plane") removed the rotation property for the
> > > cursor plane, assuming the cursor would always be displayed without
> > > any rotation. However the rotation is inherited from the underlying
> > > plane.
> > > 
> > > As a result, if the primary plane is rotated, then the cursor plane
> > > will incorrectly be rotated as well even though it doesn't have a
> > > rotation property.
> > > 
> > > To fix this, check that the underlying plane isn't rotated.
> > 
> > HW cursor works with a rotated screen on KDE on AMD HW. This
> > looks like it will break that.
> 
> Sorry, scrap that. KDE seems to do a SW rotation with HW cursor.

Actually, you're right still: I've tested again with a rotate-90 primary
plane and a cursor plane via the tentative tool, and the cursor FB is
not rotated.

So please, disregard this patch and the next one.