[PATCH v3 3/4] amd/display: add cursor rotation check

[Michel Dänzer]

On 8/17/23 15:46, Harry Wentland wrote:
> On 2023-08-17 09:44, Harry Wentland wrote:
>> On 2023-08-17 06:53, Simon Ser wrote:
>>> The commit 1347385fe187 ("drm/amd/display: don't expose rotation
>>> prop for cursor plane") removed the rotation property for the
>>> cursor plane, assuming the cursor would always be displayed without
>>> any rotation. However the rotation is inherited from the underlying
>>> plane.
>>>
>>> As a result, if the primary plane is rotated, then the cursor plane
>>> will incorrectly be rotated as well even though it doesn't have a
>>> rotation property.
>>>
>>> To fix this, check that the underlying plane isn't rotated.
>>>
>>
>> HW cursor works with a rotated screen on KDE on AMD HW. This
>> looks like it will break that.
>>
> 
> Sorry, scrap that. KDE seems to do a SW rotation with HW cursor.

Hmm, it does work correctly though (with Navi 14) with 180° rotation in gnome-shell, which uses plane rotation for the primary plane and pre-rotated contents for the cursor plane.

This patch results in drmModeAtomicCommit failing and the monitor losing signal instead.


Simon, how did you determine that the HW cursor contents get rotated according to the underlying planes?


-- 
Earthling Michel Dänzer            |                  https://redhat.com
Libre software enthusiast          |         Mesa and Xwayland developer