[PATCH] drm/amdgpu: expose more memory stats in fdinfo
Christian König
ckoenig.leichtzumerken at gmail.com
Mon Feb 6 09:05:22 UTC 2023
Just two nit picks:
+ seq_printf(m, "drm-evicted-visible-vram:\t%llu KiB\n",
+ stats.evicted_visible_vram/1024UL);
For the values not standardized for all DRM drivers we might want to use
amd as prefix here instead of drm.
+ uint64_t requested_gtt; /* how much userspace asked for */
We used to have automated checkers complaining about comments after members.
Kerneldoc complicent comments look like this:
/* @timestamp replaced by @rcu on dma_fence_release() */
struct rcu_head rcu;
Apart from that looks good to me.
Regards,
Christian.
Am 30.01.23 um 07:56 schrieb Marek Olšák:
> Hi,
>
> This will be used for performance investigations. The patch is attached.
>
> Thanks,
> Marek
More information about the amd-gfx
mailing list