[PATCH] drm/amdgpu: expose more memory stats in fdinfo
Marek Olšák
maraeo at gmail.com
Thu Feb 23 18:46:37 UTC 2023
Updated patch attached.
Marek
On Mon, Feb 6, 2023 at 4:05 AM Christian König <
ckoenig.leichtzumerken at gmail.com> wrote:
> Just two nit picks:
>
> + seq_printf(m, "drm-evicted-visible-vram:\t%llu KiB\n",
> + stats.evicted_visible_vram/1024UL);
>
> For the values not standardized for all DRM drivers we might want to use
> amd as prefix here instead of drm.
>
> + uint64_t requested_gtt; /* how much userspace asked for */
>
> We used to have automated checkers complaining about comments after
> members.
>
> Kerneldoc complicent comments look like this:
>
> /* @timestamp replaced by @rcu on dma_fence_release() */
> struct rcu_head rcu;
>
> Apart from that looks good to me.
>
> Regards,
> Christian.
>
> Am 30.01.23 um 07:56 schrieb Marek Olšák:
> > Hi,
> >
> > This will be used for performance investigations. The patch is attached.
> >
> > Thanks,
> > Marek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20230223/f6e27bcc/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-drm-amdgpu-expose-more-memory-stats-in-fdinfo.patch
Type: text/x-patch
Size: 9613 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20230223/f6e27bcc/attachment.bin>
More information about the amd-gfx
mailing list