[PATCH 1/2] drm/amd/display: Do not set drr on pipe commit

[Pillai, Aurabindo]

[Public]

Hi Michel,

You confirmed in another thread the monitor specific quirk for disabling FAMS fixed your hang. Fixes references the commit which adds such quirk:

de1da2f7fe25 drm/amd/display: Add monitor specific edid quirk

The intention is that these two patches should only be merged into stable trees after applying the monitor specific quirk.

--

Regards,
Jay
________________________________
From: Michel Dänzer <michel.daenzer at mailbox.org>
Sent: Thursday, July 6, 2023 6:05 AM
To: Pillai, Aurabindo <Aurabindo.Pillai at amd.com>; amd-gfx at lists.freedesktop.org <amd-gfx at lists.freedesktop.org>
Cc: Chalmers, Wesley <Wesley.Chalmers at amd.com>; Siqueira, Rodrigo <Rodrigo.Siqueira at amd.com>; Wheeler, Daniel <Daniel.Wheeler at amd.com>; Mahfooz, Hamza <Hamza.Mahfooz at amd.com>; Deucher, Alexander <Alexander.Deucher at amd.com>; Wentland, Harry <Harry.Wentland at amd.com>
Subject: Re: [PATCH 1/2] drm/amd/display: Do not set drr on pipe commit

On 7/5/23 20:07, Aurabindo Pillai wrote:
> From: Wesley Chalmers <Wesley.Chalmers at amd.com>
>
> [WHY]
> Writing to DRR registers such as OTG_V_TOTAL_MIN on the same frame as a
> pipe commit can cause underflow.
>
> [HOW]
> Move DMUB p-state delegate into optimze_bandwidth; enabling FAMS sets
> optimized_required.
>
> This change expects that Freesync requests are blocked when
> optimized_required is true.
>
> Fixes: de1da2f7fe25 ("drm/amd/display: Add monitor specific edid quirk")

Seems like inappropriate use of Fixes:, or how does this commit "fix" the referenced commit?

(Also a bit surprised to learn about that one only now, and that it landed without my confirming it actually works)


--
Earthling Michel Dänzer            |                  https://redhat.com
Libre software enthusiast          |         Mesa and Xwayland developer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20230706/8730c763/attachment.htm>