[PATCH 1/2] drm/amd/display: Add missing description to DMCUB definitions

Lakha, Bhawanpreet Bhawanpreet.Lakha at amd.com
Fri Mar 10 18:29:51 UTC 2023


[AMD Official Use Only - General]

Reviewed-by: Bhawanpreet Lakha <Bhawanpreet.Lakha at amd.com>
________________________________
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> on behalf of Aurabindo Pillai <aurabindo.pillai at amd.com>
Sent: March 10, 2023 12:48 PM
To: amd-gfx at lists.freedesktop.org <amd-gfx at lists.freedesktop.org>
Cc: Wentland, Harry <Harry.Wentland at amd.com>; Pillai, Aurabindo <Aurabindo.Pillai at amd.com>; Siqueira, Rodrigo <Rodrigo.Siqueira at amd.com>; Mahfooz, Hamza <Hamza.Mahfooz at amd.com>
Subject: [PATCH 1/2] drm/amd/display: Add missing description to DMCUB definitions

[Why&How]
Provides description for some enums used by DMCUB

Signed-off-by: Aurabindo Pillai <aurabindo.pillai at amd.com>
---
 drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h
index 734b34902fa7..4f67124d8e68 100644
--- a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h
+++ b/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h
@@ -717,7 +717,7 @@ enum dmub_cmd_type {
          */
         DMUB_CMD__PANEL_CNTL = 74,
         /**
-        * Command type used for <TODO:description>
+        * Command type used for all CAB commands.
          */
         DMUB_CMD__CAB_FOR_SS = 75,

@@ -997,6 +997,9 @@ struct dmub_rb_cmd_cab_for_ss {
         uint8_t debug_bits;     /* debug bits */
 };

+/**
+ * Enum for indicating which MCLK switch mode per pipe
+ */
 enum mclk_switch_mode {
         NONE = 0,
         FPO = 1,
--
2.39.2

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20230310/2d5dd440/attachment-0001.htm>


More information about the amd-gfx mailing list