[PATCH 2/2] drm/amd/pm: Add GC v9.4.3 thermal limits to hwmon

[Deucher, Alexander]

[AMD Official Use Only - General]

Series is:
Acked-by: Alex Deucher <alexander.deucher at amd.com>

On a somewhat related note, we should fix the hysteresis  values.  They are currently set to the min and max temperatures which IIRC was not the intent of these values in hwmon.

Alex

________________________________
From: Lazar, Lijo <Lijo.Lazar at amd.com>
Sent: Wednesday, September 20, 2023 6:40 AM
To: amd-gfx at lists.freedesktop.org <amd-gfx at lists.freedesktop.org>
Cc: Zhang, Hawking <Hawking.Zhang at amd.com>; Deucher, Alexander <Alexander.Deucher at amd.com>
Subject: [PATCH 2/2] drm/amd/pm: Add GC v9.4.3 thermal limits to hwmon

Publish max operating temperature of SOC and memory as temp*_emergency
nodes in hwmon. temp*_crit will show the throttle temperature limits.

Signed-off-by: Lijo Lazar <lijo.lazar at amd.com>
---
 drivers/gpu/drm/amd/pm/amdgpu_pm.c | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
index 2807f3bd9ebe..5d84cdcd7c0e 100644
--- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
+++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
@@ -3353,15 +3353,20 @@ static umode_t hwmon_attributes_visible(struct kobject *kobj,
                 return 0;

         /* hotspot temperature for gc 9,4,3*/
-       if ((gc_ver == IP_VERSION(9, 4, 3)) &&
-           (attr == &sensor_dev_attr_temp1_input.dev_attr.attr ||
-            attr == &sensor_dev_attr_temp1_label.dev_attr.attr))
-               return 0;
+       if (gc_ver == IP_VERSION(9, 4, 3)) {
+               if (attr == &sensor_dev_attr_temp1_input.dev_attr.attr ||
+                   attr == &sensor_dev_attr_temp1_emergency.dev_attr.attr ||
+                   attr == &sensor_dev_attr_temp1_label.dev_attr.attr)
+                       return 0;
+
+               if (attr == &sensor_dev_attr_temp2_emergency.dev_attr.attr ||
+                   attr == &sensor_dev_attr_temp3_emergency.dev_attr.attr)
+                       return attr->mode;
+       }

         /* only SOC15 dGPUs support hotspot and mem temperatures */
-       if (((adev->flags & AMD_IS_APU) || gc_ver < IP_VERSION(9, 0, 0) ||
-           (gc_ver == IP_VERSION(9, 4, 3))) &&
-            (attr == &sensor_dev_attr_temp2_crit_hyst.dev_attr.attr ||
+       if (((adev->flags & AMD_IS_APU) || gc_ver < IP_VERSION(9, 0, 0)) &&
+           (attr == &sensor_dev_attr_temp2_crit_hyst.dev_attr.attr ||
              attr == &sensor_dev_attr_temp3_crit_hyst.dev_attr.attr ||
              attr == &sensor_dev_attr_temp1_emergency.dev_attr.attr ||
              attr == &sensor_dev_attr_temp2_emergency.dev_attr.attr ||
--
2.25.1

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20230920/8ad58975/attachment.htm>