[PATCH 30/43] drm/amd/display: Enable cur_rom_en even if cursor degamma is not enabled

[Melissa Wen]

On 28/03/2024 16:50, Roman.Li at amd.com wrote:
> From: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
>
> Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
> Tested-by: Daniel Wheeler <daniel.wheeler at amd.com>
> ---
>   drivers/gpu/drm/amd/display/dc/dpp/dcn30/dcn30_dpp.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dpp/dcn30/dcn30_dpp.c b/drivers/gpu/drm/amd/display/dc/dpp/dcn30/dcn30_dpp.c
> index f8c0cee34080..ed1e2f65f5b5 100644
> --- a/drivers/gpu/drm/amd/display/dc/dpp/dcn30/dcn30_dpp.c
> +++ b/drivers/gpu/drm/amd/display/dc/dpp/dcn30/dcn30_dpp.c
> @@ -395,9 +395,7 @@ void dpp3_set_cursor_attributes(
>   
>   	if (color_format == CURSOR_MODE_COLOR_PRE_MULTIPLIED_ALPHA ||
>   		color_format == CURSOR_MODE_COLOR_UN_PRE_MULTIPLIED_ALPHA) {
> -		if (cursor_attributes->attribute_flags.bits.ENABLE_CURSOR_DEGAMMA) {
> -			cur_rom_en = 1;
> -		}
> +		cur_rom_en = 1;
ugh. At first glance, I think it will cause a regression with legacy gamma.

For references:
- https://gitlab.freedesktop.org/drm/amd/-/issues/1513
- https://lore.kernel.org/amd-gfx/20230731083505.1500965-1-mwen@igalia.com/
- https://lore.kernel.org/amd-gfx/20230824133810.10627-1-mwen@igalia.com/

BR,

Melissa
>   	}
>   
>   	REG_UPDATE_3(CURSOR0_CONTROL,