[PATCH] drm/amdgpu: skip ip dump if devcoredump flag is set

[Khatri, Sunil]

On 4/25/2024 7:43 PM, Lazar, Lijo wrote:
>
> On 4/25/2024 3:53 PM, Sunil Khatri wrote:
>> Do not dump the ip registers during driver reload
>> in passthrough environment.
>>
>> Signed-off-by: Sunil Khatri<sunil.khatri at amd.com>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 10 ++++++----
>>   1 file changed, 6 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>> index 869256394136..b50758482530 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>> @@ -5372,10 +5372,12 @@ int amdgpu_do_asic_reset(struct list_head *device_list_handle,
>>   		amdgpu_reset_reg_dumps(tmp_adev);
> Probably not related, can the above step be clubbed with what's being
> done below? Or, can we move all such to start with amdgpu_reset_dump_*?
Sure lizo

I will club both dump_ip_state and amdgpu_reset_reg_dumps under one if 
condition in the patch to push.

Regards Sunil

>>   
>>   	/* Trigger ip dump before we reset the asic */
>> -	for (i = 0; i < tmp_adev->num_ip_blocks; i++)
>> -		if (tmp_adev->ip_blocks[i].version->funcs->dump_ip_state)
>> -			tmp_adev->ip_blocks[i].version->funcs->dump_ip_state(
>> -				(void *)tmp_adev);
>> +	if (!test_bit(AMDGPU_SKIP_COREDUMP, &reset_context->flags)) {
>> +		for (i = 0; i < tmp_adev->num_ip_blocks; i++)
>> +			if (tmp_adev->ip_blocks[i].version->funcs->dump_ip_state)
>> +				tmp_adev->ip_blocks[i].version->funcs
>> +				->dump_ip_state((void *)tmp_adev);
>> +	}
>
> Anyway,
>
> Reviewed-by: Lijo Lazar<lijo.lazar at amd.com>
>
> Thanks,
> Lijo
>>   
>>   	reset_context->reset_device_list = device_list_handle;
>>   	r = amdgpu_reset_perform_reset(tmp_adev, reset_context);
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20240425/6b311198/attachment.htm>