[PATCH 3/4 V3] drm/amdgpu: fix invadate operation for pg_flags

[Deucher, Alexander]

[AMD Official Use Only - AMD Internal Distribution Only]

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
________________________________
From: Jesse Zhang <jesse.zhang at amd.com>
Sent: Tuesday, May 21, 2024 3:17 AM
To: amd-gfx at lists.freedesktop.org <amd-gfx at lists.freedesktop.org>
Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Koenig, Christian <Christian.Koenig at amd.com>; Huang, Tim <Tim.Huang at amd.com>; Zhang, Jesse(Jie) <Jesse.Zhang at amd.com>; Zhang, Jesse(Jie) <Jesse.Zhang at amd.com>
Subject: [PATCH 3/4 V3] drm/amdgpu: fix invadate operation for pg_flags

Since the type of pg_flags is u32, adev->pg_flags >> 16 >> 16 is 0
regardless of the values of its operands.

So removing the operations upper_32_bits and lower_32_bits.

Signed-off-by: Jesse Zhang <Jesse.Zhang at amd.com>
Suggested-by: Tim Huang <Tim.Huang at amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
index ac0ba8b8c1aa..0e1a11b6b989 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
@@ -918,7 +918,7 @@ static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf,

         /* rev==1 */
         config[no_regs++] = adev->rev_id;
-       config[no_regs++] = lower_32_bits(adev->pg_flags);
+       config[no_regs++] = adev->pg_flags;
         config[no_regs++] = lower_32_bits(adev->cg_flags);

         /* rev==2 */
@@ -935,7 +935,7 @@ static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf,
         config[no_regs++] = adev->flags & AMD_IS_APU ? 1 : 0;

         /* rev==5 PG/CG flag upper 32bit */
-       config[no_regs++] = upper_32_bits(adev->pg_flags);
+       config[no_regs++] = 0;
         config[no_regs++] = upper_32_bits(adev->cg_flags);

         while (size && (*pos < no_regs * 4)) {
--
2.25.1

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20240521/efd15ece/attachment.htm>