[PATCH] drm/amdgpu: handle default profile on GC 9.4.1

[Alex Deucher]

Please double check the COMPUTE profile set by KFD as well.

Thanks,

Alex

On Mon, Oct 21, 2024 at 9:18 PM Feng, Kenneth <Kenneth.Feng at amd.com> wrote:

> [AMD Official Use Only - AMD Internal Distribution Only]
>
> Hi Alex,
>
> I have found another problem with the current code based on the default
> workload setting to 3D fullscreen.
>
> For example, the default workload is set to 3D fullscreen first, but in
> boot, it’s not applied yet.
>
> Then a vcn ring test comes in, sets the workload mask to vcn workload + 3D
> fullscreen. After the setting,
>
> Actually the workload mask is updated to vcn workload only. Then after the
> vcn ring test, the workload doesn’t go
>
> to 3D fullscreen workload. It goes to bootup
> workload(PP_SMC_POWER_PROFILE_BOOTUP_DEFAULT).
>
> Let me try to fix it by today and get back to you.
>
> For this patch itself, it’s ok.
>
> Reviewed-by: Kenneth Feng kenneth.feng at amd.com
>
>
>
>
>
>
>
> *From:* amd-gfx <amd-gfx-bounces at lists.freedesktop.org> *On Behalf Of *Deucher,
> Alexander
> *Sent:* Tuesday, October 22, 2024 4:35 AM
> *To:* amd-gfx at lists.freedesktop.org
> *Subject:* Re: [PATCH] drm/amdgpu: handle default profile on GC 9.4.1
>
>
>
> [AMD Official Use Only - AMD Internal Distribution Only]
>
>
>
> *Caution:* This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
>
> [AMD Official Use Only - AMD Internal Distribution Only]
>
>
>
> Ping?
> ------------------------------
>
> *From:* Deucher, Alexander <Alexander.Deucher at amd.com>
> *Sent:* Friday, October 18, 2024 3:20 PM
> *To:* amd-gfx at lists.freedesktop.org <amd-gfx at lists.freedesktop.org>
> *Cc:* Deucher, Alexander <Alexander.Deucher at amd.com>
> *Subject:* [PATCH] drm/amdgpu: handle default profile on GC 9.4.1
>
>
>
> It does not support fullscreen 3D.
>
> Fixes: 336568de918e ("drm/amdgpu/swsmu: default to fullscreen 3D profile
> for dGPUs")
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> ---
>  drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
> b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
> index accc96a03bd9..4b816c7e94fe 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
> @@ -1267,7 +1267,8 @@ static int smu_sw_init(struct amdgpu_ip_block
> *ip_block)
>          smu->workload_prority[PP_SMC_POWER_PROFILE_COMPUTE] = 5;
>          smu->workload_prority[PP_SMC_POWER_PROFILE_CUSTOM] = 6;
>
> -       if (smu->is_apu)
> +       if (smu->is_apu ||
> +           (amdgpu_ip_version(adev, GC_HWIP, 0) == IP_VERSION(9, 4, 1)))
>                  smu->workload_mask = 1 <<
> smu->workload_prority[PP_SMC_POWER_PROFILE_BOOTUP_DEFAULT];
>          else
>                  smu->workload_mask = 1 <<
> smu->workload_prority[PP_SMC_POWER_PROFILE_FULLSCREEN3D];
> --
> 2.46.2
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20241022/aac636d0/attachment.htm>