[PATCH] drm/amdgpu: skip coredump after job timeout in SRIOV

[Deucher, Alexander]

[AMD Official Use Only - AMD Internal Distribution Only]

Acked-by: Alex Deucher <alexander.deucher at amd.com>
________________________________
From: Yin, ZhenGuo (Chris) <ZhenGuo.Yin at amd.com>
Sent: Thursday, September 19, 2024 1:53 AM
To: amd-gfx at lists.freedesktop.org <amd-gfx at lists.freedesktop.org>
Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Chen, Jingwen <Jingwen.Chen at amd.com>; cao, lin <lin.cao at amd.com>; Yin, ZhenGuo (Chris) <ZhenGuo.Yin at amd.com>
Subject: [PATCH] drm/amdgpu: skip coredump after job timeout in SRIOV

VF FLR will be triggered by host driver before job timeout,
hence the error status of GPU get cleared. Performing a
coredump here is unnecessary.

Signed-off-by: ZhenGuo Yin <zhenguo.yin at amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
index 381c886298bf..13a3604cf107 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
@@ -107,8 +107,11 @@ static enum drm_gpu_sched_stat amdgpu_job_timedout(struct drm_sched_job *s_job)
         /*
          * Do the coredump immediately after a job timeout to get a very
          * close dump/snapshot/representation of GPU's current error status
+        * Skip it for SRIOV, since VF FLR will be triggered by host driver
+        * before job timeout
          */
-       amdgpu_job_core_dump(adev, job);
+       if (!amdgpu_sriov_vf(adev))
+               amdgpu_job_core_dump(adev, job);

         if (amdgpu_gpu_recovery &&
             amdgpu_ring_soft_recovery(ring, job->vmid, s_job->s_fence->parent)) {
--
2.35.1

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20240919/52385fe0/attachment-0001.htm>