[AMD Official Use Only - AMD Internal Distribution Only]
Reviewed-by: Ce Sun <cesun102 at amd.com>
________________________________
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> on behalf of Khatri, Sunil <sukhatri at amd.com>
Sent: Saturday, April 12, 2025 12:33 AM
To: Deucher, Alexander <Alexander.Deucher at amd.com>; amd-gfx at lists.freedesktop.org <amd-gfx at lists.freedesktop.org>
Subject: Re: [PATCH] drm/amdgpu: fix no_user_submission check for SDMA
Reviewed-by: Sunil Khatri <sunil.khatri at amd.com>
On 4/11/2025 6:20 PM, Alex Deucher wrote:
> Copy paste typo. Use the flag from the sdma structure.
>
> Fixes: 4310acd4464b ("drm/amdgpu: add ring flag for no user submissions")
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
> index 0ba3ef1e4a068..6a42dea775b10 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
> @@ -427,7 +427,7 @@ static int amdgpu_hw_ip_info(struct amdgpu_device *adev,
> type = AMD_IP_BLOCK_TYPE_SDMA;
> for (i = 0; i < adev->sdma.num_instances; i++)
> if (adev->sdma.instance[i].ring.sched.ready &&
> - !adev->gfx.gfx_ring[i].no_user_submission)
> + !adev->sdma.instance[i].ring.no_user_submission)
> ++num_rings;
> ib_start_alignment = 256;
> ib_size_alignment = 4;
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20250414/76064ddc/attachment.htm>